replace Redis with an embedded SQLite string->string KV store (group commit, in-tx events, SQL search)

internal/api/files_register_test.go

@@ -9,24 +9,16 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/alicebob/miniredis/v2"
 	"github.com/metazla/meta-core/internal/config"
-	"github.com/metazla/meta-core/internal/storage"
 )
 
-// newRegisterTestServer wires handleRegisterFile to an in-memory Redis and a
-// temp FILES_PATH. Built directly, not through NewServer, so no watcher runs —
+// newRegisterTestServer wires handleRegisterFile to a temp store and a temp
+// FILES_PATH. Built directly, not through NewServer, so no watcher runs —
 // which is exactly the configuration this route exists for.
-func newRegisterTestServer(t *testing.T) (*Server, string, *miniredis.Miniredis) {
+func newRegisterTestServer(t *testing.T) (*Server, string) {
 	t.Helper()
-	mr := miniredis.RunT(t)
-	c := storage.NewClient("")
-	if err := c.Connect("redis://" + mr.Addr()); err != nil {
-		t.Fatalf("connect to miniredis: %v", err)
-	}
-	t.Cleanup(func() { _ = c.Close() })
 	files := t.TempDir()
-	return &Server{storage: c, config: &config.Config{FilesPath: files}}, files, mr
+	return &Server{storage: newTestStorage(t), config: &config.Config{FilesPath: files}}, files
 }
 
 func writeFixture(t *testing.T, files, rel, body string) string {
@@ -52,20 +44,20 @@ func postRegister(t *testing.T, s *Server, path string) (int, registerFileRespon
 	return rr.Code, resp
 }
 
-func streamLen(t *testing.T, mr *miniredis.Miniredis) int {
+func streamLen(t *testing.T, s *Server) int {
 	t.Helper()
-	entries, err := mr.Stream("file:events")
+	n, err := s.storage.GetStreamLength("file:events")
 	if err != nil {
-		return 0
+		t.Fatalf("stream length: %v", err)
 	}
-	return len(entries)
+	return int(n)
 }
 
 // The whole point of the route: with the watcher off, a file written under
 // plugin/ becomes a record resolvable by its midhash, and meta-share hears
 // about it on file:events.
 func TestRegisterFile_MintsAliasAndPublishesEvent(t *testing.T) {
-	s, files, mr := newRegisterTestServer(t)
+	s, files := newRegisterTestServer(t)
 	rel := "plugin/subtitles/ab12cd34.eng.srt"
 	full := writeFixture(t, files, rel, "1\n00:00:01,000 --> 00:00:02,000\nHello\n")
 
@@ -85,20 +77,19 @@ func TestRegisterFile_MintsAliasAndPublishesEvent(t *testing.T) {
 		t.Fatalf("filePath = %q, want %q", fp, full)
 	}
 
-	entries, err := mr.Stream("file:events")
+	entries, err := s.storage.XRevRange("file:events", "+", "-", 0)
 	if err != nil || len(entries) != 1 {
 		t.Fatalf("want exactly one file:events entry, got %d err=%v", len(entries), err)
 	}
-	vals := strings.Join(entries[0].Values, "|")
-	if !strings.Contains(vals, "midhash256|"+resp.CID) || !strings.Contains(vals, "path|"+rel) {
-		t.Fatalf("event must carry the midhash and the relative path, got %q", vals)
+	if vals := entries[0].Values; vals["midhash256"] != resp.CID || vals["path"] != rel {
+		t.Fatalf("event must carry the midhash and the relative path, got %v", vals)
 	}
 }
 
 // Re-uploading the same subtitle is a no-op: same root, no second event (which
 // would make meta-share re-chunk and re-provide the file).
 func TestRegisterFile_IsIdempotent(t *testing.T) {
-	s, files, mr := newRegisterTestServer(t)
+	s, files := newRegisterTestServer(t)
 	rel := "plugin/subtitles/same.eng.srt"
 	writeFixture(t, files, rel, "same bytes")
 
@@ -110,7 +101,7 @@ func TestRegisterFile_IsIdempotent(t *testing.T) {
 	if second.Root != first.Root || second.CID != first.CID {
 		t.Fatalf("second register must return the same record: %+v vs %+v", second, first)
 	}
-	if n := streamLen(t, mr); n != 1 {
+	if n := streamLen(t, s); n != 1 {
 		t.Fatalf("an idempotent re-register must not publish again, stream has %d", n)
 	}
 }
@@ -118,7 +109,7 @@ func TestRegisterFile_IsIdempotent(t *testing.T) {
 // Only plugin output may be registered here. /files/watch is the user's
 // library and belongs to the watcher; traversal must not escape either.
 func TestRegisterFile_RejectsPathsOutsidePlugin(t *testing.T) {
-	s, files, _ := newRegisterTestServer(t)
+	s, files := newRegisterTestServer(t)
 	writeFixture(t, files, "watch/movie.mkv", "x")
 	for _, p := range []string{
 		"", "plugin", "plugin/", "watch/movie.mkv", "/watch/movie.mkv",
@@ -131,7 +122,7 @@ func TestRegisterFile_RejectsPathsOutsidePlugin(t *testing.T) {
 }
 
 func TestRegisterFile_MissingFileAndDirectory(t *testing.T) {
-	s, files, _ := newRegisterTestServer(t)
+	s, files := newRegisterTestServer(t)
 	if code, _ := postRegister(t, s, "plugin/subtitles/nope.srt"); code != http.StatusNotFound {
 		t.Errorf("missing file: want 404, got %d", code)
 	}